Auto Remove Deleted Subscribers from topic #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dev-web-novu failed.
|
LetItRock
approved these changes
Feb 13, 2024
Comment on lines
+40
to
+44
| await this.topicSubscribersRepository.delete({ | ||
| _environmentId: subscriber._environmentId, | ||
| _organizationId: subscriber._organizationId, | ||
| externalSubscriberId: subscriber.subscriberId, | ||
| }); |
There was a problem hiding this comment.
wow, that was easy peasy :D
There was a problem hiding this comment.
easy peasy but we postponed the async matter here, but imo we definitely should start the discussion in order to support possible long processing into an async service like an external queue.
REF https://linear.app/novu/issue/NV-3230/auto-remove-deleted-subscribers-from-topic#comment-13955c84
djabarovgeorge
deleted the
nv-3230-1-auto-remove-deleted-subscribers-from-topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Subscribers can be added in topic using subscriberId.
Subscriber can be deleted later using API or SDK, however a user manually also has to delete them from every topic they where apart of.
Why was this change needed?
If subscriber is deleted, it is still part of topic
Currently user had to call API to first check if subscriber is part of any topic then remove that subscriber from topic.
Definition of Done