feat: add workflow creation from blueprint #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonjoel82
force-pushed
the
NV-3243_onboarding-in-app
branch
from
b7b0728
to
b4d29fd
Compare
Base automatically changed from
NV-3243_onboarding-in-app
to
usecase-onboarding-project
February 13, 2024 20:17
antonjoel82
approved these changes
Feb 13, 2024
Comment on lines
+40
to
+47
| onSuccess: (data) => { | ||
| if (data) { | ||
| const { name: blueprintName } = getWorkflowBlueprintDetails(data.name); | ||
| createTemplateFromBlueprint({ | ||
| blueprint: { ...data, name: blueprintName }, | ||
| params: { __source: TemplateCreationSourceEnum.ONBOARDING_GET_STARTED }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
❔ question: Is this function async? If so, we need to await or return createTemplateFromBlueprint, right?
Comment on lines
+3
to
+12
| export const getWorkflowBlueprintDetails = (templateName: string): { name: string; iconName: IconName } => { | ||
| const regexResult = /^:.{1,}:/.exec(templateName); | ||
| let name = ''; | ||
| let iconName = 'fa-solid fa-question'; | ||
| if (regexResult !== null) { | ||
| name = templateName.replace(regexResult[0], '').trim(); | ||
| iconName = regexResult[0].replace(/:/g, '').trim(); | ||
| } | ||
|
|
||
| return { name, iconName: iconName as IconName }; |
There was a problem hiding this comment.
💭 thought: I realize this is just refactoring / moving this, but this IconName coupling is going to be a problem with de-coupling from our icon set(s)
There was a problem hiding this comment.
what do you mean by our icon set(s)?
small note: this logic was created so we could store icons by string conversion, this way we can store them easily in the template store under workflow.name
There was a problem hiding this comment.
Yeah, this is a tough one because we're tightly coupled with FontAwesome as an icon set due to this implementation
antonjoel82
force-pushed
the
nv-3500-create-use-case-workflow-from-blueprint
branch
from
0f7ff54
to
6ccea0b
Compare
- Add all static links for each use case - Connect In-App tab to specific Integration store side panel - Create abstraction to make adding animations easier for the different color schemes - Fix Timeline styling in light mode
…e-workflow-from-blueprint
djabarovgeorge
merged commit 0116ed9
into
usecase-onboarding-project
23 of 24 checks passed
djabarovgeorge
deleted the
nv-3500-create-use-case-workflow-from-blueprint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Create a component that will be responsible for the creation of a use case workflow from a blueprint.
Why was this change needed?
So we could reuse it across the get started onboarding.
Other information (Screenshots)