feat: add fallback lng #5222
Merged
feat: add fallback lng #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiswaViraj
approved these changes
Feb 20, 2024
Base automatically changed from
nv-3511-implement-avatar-and-cta-buttons-preview-for-in-app
to
nv-2993-reusable-in-app-preview-component
February 20, 2024 11:57
…-use-default-locale-of-the-organization-as-fallback
ainouzgali
merged commit c627999
into
nv-2993-reusable-in-app-preview-component
18 checks passed
ainouzgali
deleted the
nv-3520-use-default-locale-of-the-organization-as-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
enterprise PR
When a subscriber has a locale set for him - but there is no such locale for the translation group -> use the default locale of the organization as a fallback.
Currently - it shows the translation keys in the content.
For example:
Organization default locale is en_US
The subscriber locale is en_CA
In the editor there is {{i18n group.key}}and the group has a translation file for en_US but not one for en_CA.
Currently, for this subscriber it will show in the message the text group.key
It should show the translation provided for the default locale
Why was this change needed?
Other information (Screenshots)