Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NV-3497 - Pagination Tweaks #5242

Merged
merged 2 commits into from Feb 27, 2024
Merged

NV-3497 - Pagination Tweaks #5242

merged 2 commits into from Feb 27, 2024

Conversation

antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 commented Feb 27, 2024 •
edited

What change does this PR introduce?

  • Change GoToInput to controlled input to reset the value onBlur; uncontrolled was auto-clamping despite attempting to reset the value via a ref.
  • Disable autocomplete / autosuggest -- MANTINE, WHY?!
  • Remove invalid prop from being passed to the DOM

Why was this change needed?

Other information (Screenshots)

  • I am unable to reproduce autocomplete in Dev anyway, so some help would be appreciated here!

Note: no warnings in the console about isCurrentPage being an invalid DOM prop

https://www.loom.com/share/0ec132d17e9c4167a6783720dded96d5?sid=3954ff36-da84-47ee-9c31-ec0684f952ce

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2024 •
edited

❌ Deploy Preview for dev-web-novu failed.

Name Link
🔨 Latest commit b633007
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/65de0c13111427000879bdb3

@antonjoel82 antonjoel82 changed the title Nv 3497 pagination fixes NV-3497 - Pagination Tweaks Feb 27, 2024
@linear Linear
Copy link

linear bot commented Feb 27, 2024

NV-3497 Fix "Go to page" behaviour for pagination

@antonjoel82 antonjoel82 marked this pull request as ready for review February 27, 2024 16:38
LetItRock
LetItRock approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce the autocomplete as well. Good job! 🙌

@antonjoel82 antonjoel82 merged commit df51622 into next Feb 27, 2024
21 of 26 checks passed
@antonjoel82 antonjoel82 deleted the NV-3497_pagination-fixes branch February 27, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LetItRock LetItRock LetItRock approved these changes

Assignees
No one assigned
Labels
@novu/design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonjoel82 @LetItRock