Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart #5495

Merged
merged 1 commit into from
May 4, 2024
Merged

fix: helm chart #5495

merged 1 commit into from
May 4, 2024

Conversation

aj-ya
Copy link
Contributor

@aj-ya aj-ya commented May 4, 2024

What changed? Why was the change needed?

volumeMounts key was missing in deployment template file. have added it.

Associated Error on executing helm template:

Error: YAML parse error on novu/templates/api/deployment.yaml: error converting YAML to JSON: yaml: line 155: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 155: did not find expected key
YAML parse error on novu/templates/api/deployment.yaml
helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort
        helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146
helm.sh/helm/v3/pkg/releaseutil.SortManifests
        helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106
helm.sh/helm/v3/pkg/action.(*Configuration).renderResources
        helm.sh/helm/v3/pkg/action/action.go:168
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
        helm.sh/helm/v3/pkg/action/install.go:304
main.runInstall
        helm.sh/helm/v3/cmd/helm/install.go:306
main.newTemplateCmd.func2
        helm.sh/helm/v3/cmd/helm/template.go:95
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.8.0/command.go:983
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.8.0/command.go:1115
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.8.0/command.go:1039
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:267
runtime.goexit
        runtime/asm_amd64.s:1650

@aj-ya aj-ya requested a review from a team as a code owner May 4, 2024 07:40
@aj-ya aj-ya requested review from scopsy and Cliftonz and removed request for a team May 4, 2024 07:40
Copy link

netlify bot commented May 4, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 91bb56a

Copy link

netlify bot commented May 4, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 91bb56a
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6635e67fc81c0100082ffe6e
😎 Deploy Preview https://deploy-preview-5495--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cliftonz Cliftonz merged commit fb347b8 into novuhq:next May 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants