Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Information Architecture] Refactor to Fix Brand Tests #5506

Merged
merged 5 commits into from
May 6, 2024

Conversation

BiswaViraj
Copy link
Contributor

What changed? Why was the change needed?

  • refactored the routes to fix the tests.

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@BiswaViraj BiswaViraj requested a review from a team as a code owner May 6, 2024 13:04
Copy link

netlify bot commented May 6, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 6f8ca09
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/663904a0dfb9d20008ae6d1a
😎 Deploy Preview https://deploy-preview-5506--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 6f8ca09
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/663904a02a335f0008be5f2c
😎 Deploy Preview https://deploy-preview-5506--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

As discussed, we still have an issue with routing due to LaunchDarkly, but we'll approach this in a different PR. For now, it just causes an issue that we're able to load /brand when the flag is enabled

@antonjoel82 antonjoel82 mentioned this pull request May 6, 2024
@antonjoel82 antonjoel82 changed the title refactor: routes to fix tests [Information Architecture] Refactor to Fix Brand Tests May 6, 2024
@antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 merged commit 668cb92 into next May 6, 2024
32 checks passed
@antonjoel82 antonjoel82 deleted the fix-ia-tests branch May 6, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants