Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Fixing chat missing in events interface #5661

Merged
merged 25 commits into from
Jun 12, 2024
Merged
Changes from 8 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4d3b878
adding chat to overrides interface
ameensom May 28, 2024
e837799
Merge branch 'novuhq:next' into next
ameensom May 29, 2024
869b3f3
feat(providers): adding mobishastra sms provider
ameensom May 29, 2024
5ce88a0
Merge branch 'next' into next
ameensom May 31, 2024
7371a28
Merge branch 'next' into next
ameensom May 31, 2024
39a9543
fix(node): remove code unrelated to fix
ameensom Jun 1, 2024
d30a74a
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 1, 2024
9e8eb45
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 3, 2024
8fd34b4
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 3, 2024
0ecb06b
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 3, 2024
e3ba4b6
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 3, 2024
5ed67d6
fix(node): Add missing 'chat' property to ITriggerOverrides interface
ameensom Jun 3, 2024
f338a85
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 4, 2024
6c77bc9
fix(events): Add 'whatsapp' property to ITriggerOverrides interface
ameensom Jun 4, 2024
2dc18ec
refactor(events): Update IWhatsappOverrides interface to use IWhatsap…
ameensom Jun 4, 2024
f37b0c1
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 4, 2024
4f13ccc
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 5, 2024
249258f
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 6, 2024
54dab5e
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 8, 2024
d0dd4ac
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 10, 2024
d2836ba
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 11, 2024
d3fe9e4
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 11, 2024
67c282b
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 11, 2024
d7f53fa
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 12, 2024
ee7f0e2
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom Jun 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/node/src/lib/events/events.interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export type ITriggerOverrides = {
| 'plivo'
| 'postmark'
| 'sendgrid'
| 'chat'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are seeking to introduce stronger typing across out SDKs. This fallback into object creates a weak typing for chat.

Can we follow a similar pattern as email below, creating an IChatOverrides interface and listing the necessary properties to expose in a strongly typed way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree,
i've pushed a minor change that adds the expected keys inside template object, however I think we need to add more types, hence we have media sending and interactive messages, it does have lots of variety in it, i'll try to add more soon,
Let me know if the last change is good so I can move on with the other message types

| 'twilio']?: object;
} & {
[key in 'fcm']?: ITriggerOverrideFCM;
Expand Down
Loading