Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes in the CONTIBUTING.md file for ports information #637

Merged
merged 1 commit into from Jun 9, 2022
Merged

Made changes in the CONTIBUTING.md file for ports information #637

merged 1 commit into from Jun 9, 2022

Conversation

AakashRaj20
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • An outline of the different ports used by the services the projects spins up:

3000 - API
3002 - WebSocket service
4200 - Web Management UI
4500 - Iframe embed for notification center

@vercel
Copy link

vercel bot commented Jun 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 7:50AM (UTC)

Copy link
Contributor

@davidsoderberg davidsoderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks good, thanks for you contribution 🎉

@AakashRaj20
Copy link
Contributor Author

To me this looks good, thanks for you contribution tada

Thanks for all the help

@AakashRaj20
Copy link
Contributor Author

To me this looks good, thanks for you contribution

Just one Last Question,
How will I know if my PR was merged?

@davidsoderberg
Copy link
Contributor

I have asked @scopsy to look at your change and merge it if he agrees with me 😄

@AakashRaj20
Copy link
Contributor Author

I have asked @scopsy to look at your change and merge it if he agrees with me smile

Thanks for the help hope the pr gets accepted

@davidsoderberg
Copy link
Contributor

@AakashRaj20 I got okay from @scopsy so I merge it now, thanks for your help 🙏

@davidsoderberg davidsoderberg merged commit efdf6ae into novuhq:main Jun 9, 2022
@AakashRaj20
Copy link
Contributor Author

@AakashRaj20 I got okay from @scopsy so I merge it now, thanks for your help pray

Thanks for the help with my first PR .
Will continue to contribute more to the community

@nevo-david
Copy link
Contributor

Hi @AakashRaj20 !
Welcome to the contributor's page! :)
https://novu.co/contributors/AakashRaj20/

@AakashRaj20
Copy link
Contributor Author

Hi @AakashRaj20 !
Welcome to the contributor's page! :)
https://novu.co/contributors/AakashRaj20

Thank you will contribute more to the community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants