Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add redirect / to /docs #717

Merged
merged 13 commits into from Jun 26, 2022
Merged

fix: add redirect / to /docs #717

merged 13 commits into from Jun 26, 2022

Conversation

vannyle
Copy link
Contributor

@vannyle vannyle commented Jun 22, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This pull request removes a prefix /docs in URL, and add a redirect from /docs/* to /* pages
  • What is the current behavior? (You can also link to an open issue here)
    When you open the home page of documentation, it opens a page with button Get started. It doesn't seem useful.

image

  • What is the new behavior (if this is a feature change)?
    The home page of documentation will be /

image

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 6:35AM (UTC)

@scopsy
Copy link
Contributor

scopsy commented Jun 23, 2022

Thanks @vannyle ! Is it possible to remove the docs prefix altogether just as we discussed with Alex? Since we already have the docs part in the subdomain?

@vercel
Copy link

vercel bot commented Jun 23, 2022

@vannyle is attempting to deploy a commit to the Novu Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 23, 2022

Deployment failed with the following error:

`rewrites[0]` should NOT have additional property `permanent`

@vercel
Copy link

vercel bot commented Jun 23, 2022

Deployment failed with the following error:

`rewrites[0]` should NOT have additional property `statusCode`

@scopsy scopsy merged commit 8a5366c into novuhq:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants