Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for google cloud storage #934

Merged
merged 1 commit into from Aug 3, 2022
Merged

feat: add support for google cloud storage #934

merged 1 commit into from Aug 3, 2022

Conversation

Lian1230
Copy link
Contributor

@Lian1230 Lian1230 commented Aug 2, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature. Addressing issue Allow non AWS infrastructure setups NV-681 #865
  • What is the current behavior? (You can also link to an open issue here)
    AWS s3 is the only supported storage service
  • What is the new behavior (if this is a feature change)?
    Can switch to google cloud storage with .env change
  • Other information:

@vercel
Copy link

vercel bot commented Aug 2, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 1:39PM (UTC)

scopsy
scopsy approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome Lian, thanks for contributing!

@alaboudi
Copy link

alaboudi commented Aug 2, 2022 •
edited

@Lian1230 maybe you can be assigned to #865. It's pretty much this task.

@alaboudi alaboudi mentioned this pull request Aug 2, 2022
Closed
@Lian1230
Copy link
Contributor Author

Lian1230 commented Aug 2, 2022 •
edited

@scopsy can you double check the pnpm-lock pls? I only add one dependency and not sure why it generates so many changes.

@scopsy
Copy link
Contributor

scopsy commented Aug 3, 2022

@Lian1230 lock file looks great!

@scopsy scopsy merged commit 754e230 into novuhq:main Aug 3, 2022
@Lian1230 Lian1230 deleted the novu-pr-gcs branch August 4, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lian1230 @alaboudi @scopsy