fix: upgrade mongoose to 6.4.6 #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @scopsy I upgraded the mongoose to a snyk approved version, could you or your team do some proper manual test since it's a major version upgrade? |
|
Hi @Lian1230 I will start the automatic test now and let see so they pass |
|
@Lian1230 please look at the failing tests :) |
Lian1230
force-pushed
the
pr-update-mongoose
branch
from
321ed68
to
93586d0
Compare
Lian1230
force-pushed
the
pr-update-mongoose
branch
from
93586d0
to
6b8d55d
Compare
|
@davidsoderberg @scopsy Finanlly I fixed it and the api test and test:e2e pass locally, can you please re-trigger the test workflow? |
scopsy
reviewed
Aug 7, 2022
libs/dal/src/repositories/notification-template/notification-template.schema.ts
Show resolved
Hide resolved
scopsy
reviewed
Aug 7, 2022
scopsy
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a security vulnerability
https://security.snyk.io/vuln/SNYK-JS-MONGOOSE-2961688
nothing