Issue #281 bars on multibar and discretebar now are 1 px high even if…

… they are 0
novus · Oct 25, 2012 · cf9bb41 · cf9bb41
1 parent b0947dc
commit cf9bb41
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/nv.d3.js b/nv.d3.js
@@ -2248,13 +2248,13 @@ nv.models.discreteBar = function() {
           .attr('width', x.rangeBand() / data.length);
       d3.transition(bars)
         //.delay(function(d,i) { return i * 1200 / data[0].values.length })
-		  .attr('transform', function(d,i) {
+          .attr('transform', function(d,i) {
               return 'translate(' + x(getX(d,i)) + ', ' + (getY(d,i) < 0 ? y(0) : y(getY(d,i))) + ')'
           })
-		  .select('rect')
-		    .attr('height', function(d,i) {
-			   return Math.abs(y(getY(d,i)) - y(0))
-		     });
+        .select('rect')
+          .attr('height', function(d,i) {
+            return  Math.max(Math.abs(y(getY(d,i)) - y(0)) || 1)
+          });
 
 
       //store old scales for use in transitions on update
@@ -5126,7 +5126,7 @@ nv.models.multiBar = function() {
               return y(getY(d,i) + (stacked ? d.y0 : 0));
             })
             .attr('height', function(d,i) {
-              return Math.abs(y(d.y + (stacked ? d.y0 : 0)) - y((stacked ? d.y0 : 0)))
+              return Math.max(Math.abs(y(d.y + (stacked ? d.y0 : 0)) - y((stacked ? d.y0 : 0))),1);
             })
             .each('end', function() {
               d3.transition(d3.select(this))
@@ -5150,7 +5150,7 @@ nv.models.multiBar = function() {
                     y(getY(d,i))
                 })
                 .attr('height', function(d,i) {
-                  return Math.abs(y(getY(d,i)) - y(0))
+                  return Math.max(Math.abs(y(getY(d,i)) - y(0)),1);
                 });
             })
 

diff --git a/nv.d3.min.js b/nv.d3.min.js
diff --git a/src/models/discreteBar.js b/src/models/discreteBar.js
@@ -194,13 +194,13 @@ nv.models.discreteBar = function() {
           .attr('width', x.rangeBand() / data.length);
       d3.transition(bars)
         //.delay(function(d,i) { return i * 1200 / data[0].values.length })
-		  .attr('transform', function(d,i) {
+          .attr('transform', function(d,i) {
               return 'translate(' + x(getX(d,i)) + ', ' + (getY(d,i) < 0 ? y(0) : y(getY(d,i))) + ')'
           })
-		  .select('rect')
-		    .attr('height', function(d,i) {
-			   return Math.abs(y(getY(d,i)) - y(0))
-		     });
+        .select('rect')
+          .attr('height', function(d,i) {
+            return  Math.max(Math.abs(y(getY(d,i)) - y(0)) || 1)
+          });
 
 
       //store old scales for use in transitions on update

diff --git a/src/models/multiBar.js b/src/models/multiBar.js
@@ -222,7 +222,7 @@ nv.models.multiBar = function() {
               return y(getY(d,i) + (stacked ? d.y0 : 0));
             })
             .attr('height', function(d,i) {
-              return Math.abs(y(d.y + (stacked ? d.y0 : 0)) - y((stacked ? d.y0 : 0)))
+              return Math.max(Math.abs(y(d.y + (stacked ? d.y0 : 0)) - y((stacked ? d.y0 : 0))),1);
             })
             .each('end', function() {
               d3.transition(d3.select(this))
@@ -246,7 +246,7 @@ nv.models.multiBar = function() {
                     y(getY(d,i))
                 })
                 .attr('height', function(d,i) {
-                  return Math.abs(y(getY(d,i)) - y(0))
+                  return Math.max(Math.abs(y(getY(d,i)) - y(0)),1);
                 });
             })