Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line Chart Legend "bottom" Does Not Scale Correctly #1889

Closed
KidA78 opened this issue Dec 10, 2016 · 2 comments
Closed

Line Chart Legend "bottom" Does Not Scale Correctly #1889

KidA78 opened this issue Dec 10, 2016 · 2 comments

Comments

@KidA78
Copy link
Contributor

KidA78 commented Dec 10, 2016

NVD3 v1.8.5-dev

            var chart = nv.models.lineChart()
                .interpolate("monotone")
                .legendPosition("bottom")

When resizing the browser, the legend items sometimes gets cut off if there are too many keywords in the legend. The reason is because unlike the bottom position of the legend in the other nvd3 models, the line chart does not adjust the chart's bottom margin based on the legend height.
KidA78 pushed a commit to Traackr/nvd3 that referenced this issue Dec 10, 2016
novus#1889 Correct line chart legend bottom position, to account for …
6bd949d 
…bottom margin and xAxis
@liquidpele
Copy link
Contributor

Send me a PR to fix it and I'll merge it in :)

@KidA78
Copy link
Contributor Author

KidA78 commented Dec 10, 2016 •
edited

@liquidpele we're on the same page ;) Check out the above PR.

KidA78 pushed a commit to Traackr/nvd3 that referenced this issue Dec 10, 2016
novus#1889 Update lineChart.html with top/bottom legend toggle
c431f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liquidpele @KidA78