Line Chart Legend "bottom" Does Not Scale Correctly #1889

Closed
KidA78 opened this Issue Dec 10, 2016 · 2 comments

Projects

None yet

2 participants

@KidA78
Contributor
KidA78 commented Dec 10, 2016

NVD3 v1.8.5-dev

            var chart = nv.models.lineChart()
                .interpolate("monotone")
                .legendPosition("bottom")

When resizing the browser, the legend items sometimes gets cut off if there are too many keywords in the legend. The reason is because unlike the bottom position of the legend in the other nvd3 models, the line chart does not adjust the chart's bottom margin based on the legend height.

@KidA78 KidA78 added a commit to Traackr/nvd3 that referenced this issue Dec 10, 2016
@KidA78 KidA78 #1889 Correct line chart legend bottom position, to account for botto…
…m margin and xAxis
6bd949d
@liquidpele
Contributor

Send me a PR to fix it and I'll merge it in :)

@KidA78
Contributor
KidA78 commented Dec 10, 2016 edited

@liquidpele we're on the same page ;) Check out the above PR.

@KidA78 KidA78 added a commit to Traackr/nvd3 that referenced this issue Dec 10, 2016
@KidA78 KidA78 #1889 Update lineChart.html with top/bottom legend toggle c431f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment