Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will it be compatible with d3.v3 ? #36

Closed
firebat opened this issue Jan 17, 2013 · 11 comments
Closed

will it be compatible with d3.v3 ? #36

firebat opened this issue Jan 17, 2013 · 11 comments

Comments

@firebat
Copy link

firebat commented Jan 17, 2013

No description provided.

@rmleon
Copy link
Contributor

rmleon commented Jan 22, 2013

Maybe. Certainly we've been keeping an eye on d3.v3 and we'd like to make it compatible.

@twolfnovus
Copy link
Contributor

Some day. That's definitely a todo

@rmleon rmleon closed this as completed Jan 27, 2013
arlm pushed a commit to arlm/nvd3 that referenced this issue Feb 5, 2013
Fix accidental semicolon in var list causing variables afterwards to be globals in multiBarChart.
@danse
Copy link

danse commented Mar 18, 2013

i had some problems and lost a lot of time because of this incompatibility, since there is not component.json file nor a clear statement that just d3 version 2 is supported, i would like at least to have this issue open in order to spot it more easily

@pdwinkel
Copy link

pdwinkel commented Apr 1, 2013

+1 for d3 version 3

@matthelm
Copy link

matthelm commented Apr 4, 2013

+1 from me too

@devilankur18
Copy link

+1

@twolfnovus twolfnovus reopened this Apr 17, 2013
@twolfnovus
Copy link
Contributor

The day has come.

Check out the d3v3_Upgrade branch. It currently reflects master, but all charts have been updated to work with d3v3. I'm not merging to master yet because I'd like to test more thoroughly to make sure I didn't miss anything. Post any issues you run into so we can make master v3 compatible!

@twolfnovus
Copy link
Contributor

We're stepping up for NVD3 v0.9 update very soon. The big change in the code is d3.v3 support. Expect the update soon!

@j0hnsmith
Copy link

excellent, looking forward to it

@dzimine
Copy link

dzimine commented May 16, 2013

For your tracking: nv.utils.windowResize(chart.update) works in d3.v2, but throws exception in d3.v3 - I stepped to it for lineChart.

@robinfhu
Copy link
Contributor

robinfhu commented Aug 6, 2013

NVD3 upgraded to d3 version 3. Closing.

@robinfhu robinfhu closed this as completed Aug 6, 2013
DavidSouther added a commit that referenced this issue May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants