Performance improvements for lineChart #1282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lineChart was unified with lineWithFocusChart, a bug crept in cause the main chart to be called twice (once during the standard update, again during the onBrush() update). This patch makes those two updates to the main chart mutually exclusive, based on the focusEnable flag.
The majority of the diff is whitespace, now that the focusChart logic is wrapped by an if.
A few other changes are along for the ride: