Feature/futures

[daggerrz]

Adds support for Twitter and Scala futures by adding new Intent types: FuturePlan.Intent and TwitterFuturePlan.Intent.

It also makes future pool for regular cycle intents configurable so that blocking operations can be performed.

[softprops]

have had a lot of time to look at this closely but at a high level it looks good to me.

[chrislewis]

Thanks Dag!

UnfilteredService line 20, the cycle intent constructor takes a future pool argument but doesn't propagate that to the cycle call. I assume that's an oversight but it raises another question: what is gained by having the 3 apply methods merely proxy to the explicitly named methods (cycle, twitterFuture, scalaFuture)? I'm inclined to remove them but I want to make sure I'm not missing anything.

[daggerrz]

Yes, that's an oversight from when I added the overloaded methods, I'll get it updated tomorrow.

As for the overloading itself, I agree that it's not very pretty. The primary reason for adding them was to stay consistent while not breaking backwards compatibility. I'd probably prefer just removing all of them.

[chrislewis]

Ok no worries - I can tweak it. As for backwards compatibility, I assume you mean with extensions you've made internally (that use twitterFuture, etc)? If that's the case I'm happy to leave them there for a version or two if you have dependencies.

[daggerrz]

No problem breaking things for us - I just noticed you deprecated a method in your code, so I was trying not to break anything else.

[chrislewis]

Merged. Have a look at HEAD but there shouldn't be anything objectionable in there. Thanks again!