Separate reload and ship with prebuilt list of TLDs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DomainParser repository could already include an nearly up-to-date list of tlds (similar to the cached file it uses currently). The repository would then also include a tool to update that file manually through the command line. The update process could also be hooked into
composer install. So that if you composer install it automatically creates a very fresh list of tlds.This has the benefit of fixing issue #4 and reducing the requirement to contact remote servers for a list of TLDs. Although TLDs are added from time to time, they don't change that often that it would require a "realtime" mechanism.
This PR separates the loading from the reloading of the file and adds a prebuilt cached file but does only provide an initial implementation of a tool to refresh it.