Feature/change router #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ios/Podfile.lock # lib/services/auth.dart
# Conflicts: # lib/app/app.dart # lib/services/auth.dart # lib/services/pushNotifications.dart # lib/ui/views/intro/intro_viewmodel.dart # lib/ui/views/login/login_viewmodel.dart # lib/ui/views/tabs/tabs_view.dart
JElgar
reviewed
Apr 8, 2024
| @@ -55,7 +55,7 @@ extension DialogServiceExtension on DialogService { | |||
| Future<bool> showActionCompletedDialog() async { | |||
| final response = await showCustomDialog( | |||
| barrierDismissible: true, | |||
| variant: DialogType.actionCompleted, | |||
| variant: DialogType.emailAppPicker, | |||
| exploreFilterData: filterData, | ||
| ), | ||
| ); | ||
| return navigateToFaqView(); |
| return clearStackAndShow(route); | ||
| } | ||
| return navigateTo(route); | ||
| return navigateToTabsView(); |
There was a problem hiding this comment.
Do we still want to handle clearHistory here?
| @@ -3,7 +3,8 @@ import 'package:nowu/services/navigation_service.dart'; | |||
| import 'package:stacked/stacked.dart'; | |||
|
|
|||
| class PartnerInfoViewModel extends BaseViewModel { | |||
| final _navigationService = locator<NavigationService>(); | |||
| final _navigationService = locator<LauncherService>(); | |||
There was a problem hiding this comment.
Suggested change
| final _navigationService = locator<LauncherService>(); | |
| final _launcherService = locator<LauncherService>(); |
|
|
||
| class PartnersViewModel extends FutureViewModel<Iterable<Organisation>> { | ||
| final _causesService = locator<CausesService>(); | ||
| final _routerService = locator<RouterService>(); | ||
| final _routerService = locator<NavigationService>(); |
There was a problem hiding this comment.
Can we rename every instance of _routerService to _navigationService?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Router used in the navigation is causing app to not work correctly on iOs with blocked back swipe: Stacked-Org/stacked#1088
Fixes #254
Checklist:
Creator
Reviewer
After pull