Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

请问代码作用域问题 #23

Closed
huobazi opened this issue Apr 3, 2014 · 0 comments
Closed

请问代码作用域问题 #23

huobazi opened this issue Apr 3, 2014 · 0 comments

Comments

@huobazi
Copy link
Contributor

huobazi commented Apr 3, 2014

在 https://github.com/nowa/carrierwave-upyun/blob/master/lib/carrierwave/upyun/configuration.rb#L12
这里的end结束了 CarrierWave :: UpYun:: Configuration 这个 module。
下面ClassMethods里定义的add_config是没用到。
实际上在https://github.com/carrierwaveuploader/carrierwave/blob/master/lib/carrierwave/uploader/configuration.rb#L106 内已有同功能的code。

同样的问题在下面两个gem里也有。
https://github.com/huacnlee/carrierwave-tfs
https://github.com/huacnlee/carrierwave-aliyun

@nowa @huacnlee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huacnlee @huobazi