Refactor tests

nowsprinting · Nov 1, 2023 · 3799762 · 3799762
1 parent 1730efb
commit 3799762
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/Tests/Runtime/Attributes/FocusGameViewAttributeTest.cs b/Tests/Runtime/Attributes/FocusGameViewAttributeTest.cs
@@ -17,8 +17,8 @@ namespace TestHelper.Attributes
     public class FocusGameViewAttributeTest
     {
         [Test]
-        [FocusGameView]
         [IgnoreBatchMode("Open GameView in batchmode but can not get window.")]
+        [FocusGameView]
         public void Attach_GameViewHasFocus()
         {
             const string GameView = "UnityEditor.GameView";
@@ -31,8 +31,8 @@ public void Attach_GameViewHasFocus()
         }
 
         [Test]
-        [FocusGameView]
         [IgnoreWindowMode("For batchmode test.")]
+        [FocusGameView]
         public void Attach_KeepBatchmode()
         {
             Assert.That(Application.isBatchMode, Is.True);

diff --git a/Tests/Runtime/Attributes/GizmosShowOnGameViewAttributeTest.cs b/Tests/Runtime/Attributes/GizmosShowOnGameViewAttributeTest.cs
@@ -11,6 +11,7 @@
 namespace TestHelper.Attributes
 {
     [TestFixture]
+    [UnityPlatform(RuntimePlatform.OSXEditor, RuntimePlatform.WindowsEditor, RuntimePlatform.LinuxEditor)]
     public class GizmosShowOnGameViewAttributeTest
     {
         private class GizmoDemo : MonoBehaviour
@@ -54,18 +55,20 @@ public void Attach_False_HideGizmos()
 
         [Test]
         [CreateScene(camera: true, light: true)]
-        [GizmosShowOnGameView()]
+        [GizmosShowOnGameView]
         public async Task AttachToAsyncTest_ShowGizmos()
         {
             await Task.Yield();
+            // verify screenshot.
         }
 
         [UnityTest]
         [CreateScene(camera: true, light: true)]
-        [GizmosShowOnGameView()]
+        [GizmosShowOnGameView]
         public IEnumerator AttachToUnityTest_ShowGizmos()
         {
             yield return null;
+            // verify screenshot.
         }
     }
 }