Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line argument to specify screenshot save directory #63

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

nowsprinting
Copy link
Owner

@nowsprinting nowsprinting commented Mar 21, 2024

Screenshot save directory can be also specified by command line arguments -testHelperScreenshotDirectory.

@github-actions github-actions bot added the enhancement New feature or request label Mar 21, 2024
@nowsprinting nowsprinting changed the title Add commandline arg -testHelperScreenshotDirectory Add command line argument to specify screenshot save directory Mar 21, 2024

This comment has been minimized.

@nowsprinting nowsprinting mentioned this pull request Mar 21, 2024
1 task
@nowsprinting nowsprinting marked this pull request as ready for review March 21, 2024 22:50
Copy link

Code Metrics Report

master (0ec8626) #63 (e91482b) +/-
Coverage 65.3% 66.8% +1.5%
Code to Test Ratio 1:2.0 1:2.0 +0.1
Test Execution Time 5m6s 3m15s -1m51s
Details
  |                     | master (0ec8626) | #63 (e91482b) |  +/-   |
  |---------------------|------------------|---------------|--------|
+ | Coverage            |            65.3% |         66.8% |  +1.5% |
  |   Files             |               23 |            24 |     +1 |
  |   Lines             |              524 |           548 |    +24 |
+ |   Covered           |              342 |           366 |    +24 |
+ | Code to Test Ratio  |            1:2.0 |         1:2.0 |   +0.1 |
  |   Code              |              543 |           543 |      0 |
+ |   Test              |             1068 |          1103 |    +35 |
+ | Test Execution Time |             5m6s |         3m15s | -1m51s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/-
Runtime/Attributes/TakeScreenshotAttribute.cs 100.0% 0.0%
RuntimeInternals/CommandLineArgs.cs 100.0% +100.0%
RuntimeInternals/ScreenshotHelper.cs 100.0% 0.0%

Reported by octocov

@nowsprinting nowsprinting merged commit 82ee108 into master Mar 21, 2024
9 checks passed
@nowsprinting nowsprinting deleted the feature/screenshotpath branch March 21, 2024 22:53
nowsprinting added a commit that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant