Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress log option for screenshot #80

Merged
merged 3 commits into from
May 2, 2024

Conversation

nowsprinting
Copy link
Owner

Changes

Can suppress output filepath to Debug.Log if you need.

Usage:

yield return ScreenshotHelper.TakeScreenshot(logFilepath: false);

Other changes

  • Remove ScreenshotHelperTestSceneBuilder, using LoadSceneAttribute instead
  • Add test for DefaultFilename with parameterized

@github-actions github-actions bot added the chore label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Code Metrics Report

master (987524c) #80 (3a2701a) +/-
Coverage 71.6% 71.7% +0.1%
Code to Test Ratio 1:1.0 1:0.9 -0.0
Details
  |                    | master (987524c) | #80 (3a2701a) |  +/-  |
  |--------------------|------------------|---------------|-------|
+ | Coverage           |            71.6% |         71.7% | +0.1% |
  |   Files            |               27 |            27 |     0 |
  |   Lines            |              648 |           651 |    +3 |
+ |   Covered          |              464 |           467 |    +3 |
- | Code to Test Ratio |            1:1.0 |         1:0.9 |  -0.0 |
  |   Code             |             1261 |          1265 |    +4 |
- |   Test             |             1202 |          1189 |   -13 |

Code coverage of files in pull request scope (97.1% → 97.4%)

Files Coverage +/-
RuntimeInternals/ScreenshotHelper.cs 97.4% +0.2%

Reported by octocov

@nowsprinting nowsprinting merged commit e29638d into master May 2, 2024
9 checks passed
@nowsprinting nowsprinting deleted the chore/screenshot_suppress_log branch May 2, 2024 21:15
@nowsprinting nowsprinting added enhancement New feature or request and removed chore labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant