Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for Pebble indicates threads created with a ThreadPool are cancellable #118

Closed
vstoleru-uipath opened this issue Jul 31, 2023 · 1 comment
Closed

Documentation for Pebble indicates threads created with a ThreadPool are cancellable #118

vstoleru-uipath opened this issue Jul 31, 2023 · 1 comment

Comments

@vstoleru-uipath
Copy link

vstoleru-uipath commented Jul 31, 2023 •
edited
Loading

The latest version of the documentation seems to indicate that the schedule method of the ThreadPool object returns a ProcessFuture, which can be cancelled.

This is not the case with the current implementation and with the fact that Python does not support cancelling threads as-is (as you guys have already mentioned here).
noxdafox added a commit that referenced this issue Aug 4, 2023
@noxdafox
issue #118, doc: fix ThreadPool.schedule documentation
c7b2c92 
Signed-off-by: Matteo Cafasso <noxdafox@gmail.com>
@noxdafox
Copy link
Owner

noxdafox commented Aug 4, 2023

Hello,

issue fixed. Thanks for reporting.

@noxdafox noxdafox closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noxdafox @vstoleru-uipath