python setup clean modifies the sources #64
Comments
|
Hello,
It does so by adding the version number when running Are you trying to port |
|
well, if you call "building from source" as "porting", yes. The source packages never have access to the VCS. |
noxdafox
added a commit
that referenced
this issue
May 9, 2020
The previous versioning logic was inferring the package version through its VCS tag. This mechanism had few shortcomings: - The `setup.py` was modifying the module sources causing issues in build systems - As the VCS might not be installed on target machines, an extra `version.py` file had to be provided in the package - As the code was modified during packaging time, the source code with the correct version would be one commit ahead of the actual tagged version The new logic inverts the version control. The version is controlled within the module `__init__.py` file. When releasing a new version, the module file is updated and committed. The tag is then inferred from the module file itself. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com>
|
Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pebble has a rather unusual setup.py, which modifes the sources during the build, even when calling setup.py clean. Seen when packaging pebble. Maybe make this more robust, such that things are not modified, or not appended multiple times? My current workaround is not to call write_version at all.
--- python-pebble-4.5.1.orig/setup.py
+++ python-pebble-4.5.1/setup.py
@@ -17,7 +17,7 @@ def package_version():
#write_version(init_path, version, mode='a')
return version
The text was updated successfully, but these errors were encountered: