Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IMDSV2 #33

Closed
avivek opened this issue Jun 10, 2021 · 5 comments
Closed

Support for IMDSV2 #33

avivek opened this issue Jun 10, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@avivek
Copy link

avivek commented Jun 10, 2021

We have been using this plugin to capture the RMQ metrics @ cloudwatch for quite some time and it has been working great. Thanks a lot.

About the Enhancement:
The IMDS of AWS has a new version IMDSV2.
AWS recommends that everyone migrate to the V2 version, and has settings to turn off V1 at the machine level.
This is recommended for security reasons.

The peer_discovery_aws module has moved over:
rabbitmq/rabbitmq-server#2952

Also when I checked on the Dependency of this project ex_aws, there is a PR that is open for this:
ex-aws/ex_aws#739

It would be really helpful if we could support this enhancement for this library.

@noxdafox noxdafox added the enhancement New feature or request label Jul 25, 2021
@noxdafox
Copy link
Owner

I am not sure IMDS related changes have to do with this plugin. This plugin simply uses ex_aws to interface with AWS APIs.

The way ex_aws authenticates with AWS is out of the scope for this plugin. Is there some necessary changes to be done once said PR get merged?

@avivek
Copy link
Author

avivek commented Jul 25, 2021

When the IMDSV2 is supported on the ex_aws library, we need to upgrade the dependency here.
I think nothing else is required.

@avivek
Copy link
Author

avivek commented May 30, 2022

Hi @noxdafox the IMDSV2 supported has been merged by the ex_aws library.
Please refer to the below PR:

ex-aws/ex_aws#860

Can you please update the dependency and create a release for this.

@avivek
Copy link
Author

avivek commented Jun 14, 2022

Hi @noxdafox,

The IMDSV2 supported has been merged by the ex_aws library.
Please refer to the below PR:

ex-aws/ex_aws#860

Can you please update the dependency and create a release for this.

noxdafox added a commit that referenced this issue Jun 18, 2022
Signed-off-by: Matteo Cafasso <noxdafox@gmail.com>
@noxdafox
Copy link
Owner

Resolved in v1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants