Fix typo of Mnesia storage_type #105
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin used to crash in a distributed cluster when a node
was added to the cache replicas.
```
node 'rabbit@node-02' up
** Generic server 'Elixir.RabbitMQMessageDeduplication.CacheManager' terminating
** Last message in was {mnesia_system_event,
{mnesia_up,'rabbit@node-02'}}
** When Server state == #{}
** Reason for termination ==
** {{case_clause,
{aborted,
{badarg,cache_exchange_<name>,
ram_nodes}}},
[{'Elixir.RabbitMQMessageDeduplication.Cache',
'-cache_rebalance/1-fun-0-',4,
```
|
Hey! Thanks for your contribution! I am struggling with the test suite right now. As soon as I get the tests to run I will validate and merge! |
noxdafox
force-pushed
the
main
branch
10 times, most recently
from
f242f7a
to
c6f6da2
Compare
|
Finally managed to fix the build logic. I will test it and release during WE. Thanks again for your contribution! |
|
Fix release in version |
|
thank you for maintaining this plugin and the heroic efforts to keep the build/CI working! |
|
I would not call it heroic 😁, but it is indeed becoming harder and harder to maintain the plugin unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin used to crash in a distributed cluster when a node was added to the cache replicas because
Mnesia.add_table_copy/3was called with invalid table storage type argument.