Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to change go toolkit version for windows builder image #3

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

angrykirc
Copy link
Contributor

Add an option to change go toolkit version for windows builder image.
This is needed to make a Windows 7 compatible builds.

@angrykirc angrykirc requested a review from dennwc June 27, 2024 20:26
@angrykirc
Copy link
Contributor Author

Something is wrong, the pipeline gets stuck at "Entering fakeroot environment..." message for more than 30 minutes.
But if I try to build the image locally on my Debian laptop, everything is OK and it builds in 9mins, strange...

@dennwc
Copy link
Contributor

dennwc commented Jun 27, 2024

Maybe some GH glitch? Try restarting tomorrow.

@angrykirc
Copy link
Contributor Author

Lol, the base runner image was seemingly the culprit.
@dennwc If you are OK with the base image change (it's frequently updated anyway), I'm merging it.

Copy link
Contributor

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dennwc dennwc merged commit 380c75e into master Jun 28, 2024
2 checks passed
@dennwc dennwc deleted the option-go-toolkit branch June 28, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants