Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support user could fix sni support version #11

Closed
keedi opened this issue Feb 3, 2014 · 1 comment
Closed

feature request: support user could fix sni support version #11

keedi opened this issue Feb 3, 2014 · 1 comment

Comments

@keedi
Copy link

keedi commented Feb 3, 2014

Hello,

I already read RT #83289 and SNI support section of IO::Socket::SSL.

But sometimes if user could know exactly his ssl could support SNI or not, although its version is 0.9.8.x. Current code of IO::Socket::SSL looks like:

IO::Socket::SSL code, Line 40

if ( $can_client_sni ) {
    ...
}

...

sub can_client_sni { return $can_client_sni }

So, someone who are using ssl 0.9.8 which is backported SNI could not use SNI option. I hope to check using can_client_sni() rather than $can_client_sni lexical variable. Because If user risk the ssl 0.9.8 version then he can override can_client_sni() then he could use SNI features of his SSL.

How about change the code like:

if ( $self->can_client_sni() ) {
    ...
}

If this feature request is not
Please ignore and close this feature request if it is inappropriate. :-)

Thanks!

@noxxi
Copy link
Owner

noxxi commented Feb 4, 2014

While it would not be too hard to let the user override the detected features of openssl I don't think, that it would be a good idea. Because:

  • if the user has ported features/fixes back to an older openssl version he will probably be able to override the feature detection in IO::Socket::SSL too. This would be much better then just override it in each single application
  • if the OS provider did these fixes he should probably also do these fixes in Perl libraries coming with the OS

In my opinion this leaves only the case, where the OS has fixes, but does not ship with Perl or with IO::Socket::SSL. In this case the user either is expert enough to know, that the OS openssl has fixes for SNI - in think the user should be able to adapt IO::Socket::SSL too. Or the user has no such expert knowledge - in this case he probably does not care at all.

In any case I think the correct setting should be done for all applications in IO::Socket::SSL and not be necessary to do in each application. So if you have a reliable way to detect openssl which has these fixes backported I could incorporate it into IO::Socket::SSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants