Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for v0.1 #47

Open
8 of 12 tasks
nozavroni opened this issue Dec 31, 2016 · 0 comments
Open
8 of 12 tasks

Refactor for v0.1 #47

nozavroni opened this issue Dec 31, 2016 · 0 comments
Assignees
@nozavroni
Labels
feature next release priority refactor task
Milestone
v0.1 Release

Comments

@nozavroni
Copy link
Owner

nozavroni commented Dec 31, 2016 •
edited
Loading

Because my most recent changes have addressed so many different issues, I'm creating this issue to have a single issue number to reference and tie all the changes to. This feature branch I'm creating will address the following issues:
@nozavroni nozavroni added this to the v0.1 Release milestone Dec 31, 2016
@nozavroni nozavroni self-assigned this Dec 31, 2016
nozavroni added a commit that referenced this issue Dec 31, 2016
@nozavroni
CollectionInterface creation and integration (partial) - #47
1f083fe 
After a whole lot of refactoring and adding ALL of the new methods I wanted to add, I have finally gotten a SINGLE testcase class passing. So I'm committing it. This commit covers a LOT of ground though. I'll try to list all of it but I'm sure I'll miss something:

* Added indexOf() method - refs #20
* Added random() method - refs #39
* Added namespaced helper functions collect(), invoke(), is_traversable(), is_arrayable(), to_array(), and typeof() - refs #42
* Renamed getValueAtPosition() and getKeyAtPosition() to getOffset() and getOffsetKey() - refs #45
* Added CollectionInterface - refs #39
* Added Arrayable support with ArrayableInterface and is_arrayable() - refs #23
* Using Laravel's collections for inspiration, I rounded out my main collection mehods which are defined in CollectionInterface - refs #30
* Added to_array() method which is somewhat similar to Laravel's getArrayableItems(), but it still needs some work - refs #31
* A whole bunch of other minor changes

I still need to get the remaining unit tests working and I need to add unit tests for the new methods I added with this commit.
nozavroni added a commit that referenced this issue Dec 31, 2016
@nozavroni
Got CollectionTest working after refactor from last commit - refs #47
2904659
nozavroni added a commit that referenced this issue Dec 31, 2016
@nozavroni
Got several more test cases passing - refs #47
2c401c4
nozavroni added a commit that referenced this issue Dec 31, 2016
@nozavroni
Fixed remaining errors in object collection - refs #47
abbc512
nozavroni added a commit that referenced this issue Jan 1, 2017
@nozavroni
Added immutability tests - refs #47
6573b52 
Added some methods to my base unit test case class that allows me to "watch" an object over the course of a test and then at the end, assert that it has not changed in any discernable way. This will help me immensely while trying to unit test that my collection methods are respecting collection object immutability. I have implemented this assert method in all existing tests that warrant it.
nozavroni added a commit that referenced this issue Jan 1, 2017
@nozavroni
Began unit testing remaining CollectionInterface methods - refs #47
11d3689
nozavroni added a commit that referenced this issue Jan 1, 2017
@nozavroni
Removed IsImmutable trait from Collection\Collection - refs #47
9642d74 
* references "feature"
nozavroni added a commit that referenced this issue Jan 7, 2017
@nozavroni
Added Collection::split() - #47
e85421e
nozavroni added a commit that referenced this issue Jan 7, 2017
@nozavroni
Implemented Collection::zip() - refs #47
947fd94 
Implemented and unit tested the Collection::zip() method - refs #47
nozavroni added a commit that referenced this issue Jan 8, 2017
@nozavroni
Mostly testing of Sequence methods - refs #47
d1dd367 
* Added IsArrayable trait to Sequence
* Implemented and added tests for Sequence methods "pipe", "every", "none", and "first"
nozavroni added a commit that referenced this issue Jan 8, 2017
@nozavroni
Implemented and tested Sequence::last and Sequence::reverse() - refs #47
2ecf36c
nozavroni added a commit that referenced this issue Jan 8, 2017
@nozavroni
Added reverse method to Sequenceable interface - refs #47
baa4b50
nozavroni pushed a commit that referenced this issue Jan 8, 2017
Added several more Sequence methods and unit tests, including except,…
734d237 
… diff, and diffKeys - refs #47
nozavroni pushed a commit that referenced this issue Jan 8, 2017
Added isset tests for negative offset - refs #47
be9cc37
nozavroni pushed a commit that referenced this issue Jan 8, 2017
Added several helper functions for working with sequential ranges and…
80b736b 
… negative indexes. - refs #47
nozavroni pushed a commit that referenced this issue Jan 8, 2017
Added some tests to ensure the helper functions throw exceptions at t…
339132a 
…he appropriate times - refs #47
nozavroni pushed a commit that referenced this issue Jan 9, 2017
Fixed parse error with Stack collection - #47
c2f95aa
nozavroni pushed a commit that referenced this issue Jan 9, 2017
Added unit tests for all remaining Noz\* functions.
cd7dd53 
According to my code coverage reports, several Noz\* functions had still yet to be unit tested, either in part, or at all. This commit should cover every function in the Noz namespace. - refs #47
nozavroni pushed a commit that referenced this issue Jan 9, 2017
Began working on List collection - refs #47
02a3bd9 
 * Renamed Lst -> LList
 * Refactored Sequence::__invoke() because I intend to do something similar with LList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nozavroni nozavroni

Labels
feature next release priority refactor task
Projects
None yet
Milestone
v0.1 Release
Development

No branches or pull requests
1 participant
@nozavroni