-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for v0.1 #47
Comments
nozavroni
added a commit
that referenced
this issue
Dec 31, 2016
After a whole lot of refactoring and adding ALL of the new methods I wanted to add, I have finally gotten a SINGLE testcase class passing. So I'm committing it. This commit covers a LOT of ground though. I'll try to list all of it but I'm sure I'll miss something: * Added indexOf() method - refs #20 * Added random() method - refs #39 * Added namespaced helper functions collect(), invoke(), is_traversable(), is_arrayable(), to_array(), and typeof() - refs #42 * Renamed getValueAtPosition() and getKeyAtPosition() to getOffset() and getOffsetKey() - refs #45 * Added CollectionInterface - refs #39 * Added Arrayable support with ArrayableInterface and is_arrayable() - refs #23 * Using Laravel's collections for inspiration, I rounded out my main collection mehods which are defined in CollectionInterface - refs #30 * Added to_array() method which is somewhat similar to Laravel's getArrayableItems(), but it still needs some work - refs #31 * A whole bunch of other minor changes I still need to get the remaining unit tests working and I need to add unit tests for the new methods I added with this commit.
nozavroni
added a commit
that referenced
this issue
Dec 31, 2016
nozavroni
added a commit
that referenced
this issue
Dec 31, 2016
nozavroni
added a commit
that referenced
this issue
Dec 31, 2016
nozavroni
added a commit
that referenced
this issue
Jan 1, 2017
Added some methods to my base unit test case class that allows me to "watch" an object over the course of a test and then at the end, assert that it has not changed in any discernable way. This will help me immensely while trying to unit test that my collection methods are respecting collection object immutability. I have implemented this assert method in all existing tests that warrant it.
nozavroni
added a commit
that referenced
this issue
Jan 1, 2017
nozavroni
added a commit
that referenced
this issue
Jan 7, 2017
nozavroni
added a commit
that referenced
this issue
Jan 7, 2017
Implemented and unit tested the Collection::zip() method - refs #47
nozavroni
added a commit
that referenced
this issue
Jan 8, 2017
* Added IsArrayable trait to Sequence * Implemented and added tests for Sequence methods "pipe", "every", "none", and "first"
nozavroni
added a commit
that referenced
this issue
Jan 8, 2017
nozavroni
added a commit
that referenced
this issue
Jan 8, 2017
nozavroni
pushed a commit
that referenced
this issue
Jan 8, 2017
nozavroni
pushed a commit
that referenced
this issue
Jan 9, 2017
nozavroni
pushed a commit
that referenced
this issue
Jan 9, 2017
According to my code coverage reports, several Noz\* functions had still yet to be unit tested, either in part, or at all. This commit should cover every function in the Noz namespace. - refs #47
nozavroni
pushed a commit
that referenced
this issue
Jan 9, 2017
* Renamed Lst -> LList * Refactored Sequence::__invoke() because I intend to do something similar with LList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because my most recent changes have addressed so many different issues, I'm creating this issue to have a single issue number to reference and tie all the changes to. This feature branch I'm creating will address the following issues:
The text was updated successfully, but these errors were encountered: