Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Data Type #29

Closed
ishahrier opened this issue Feb 8, 2016 · 4 comments
Closed

Wrong Data Type #29

ishahrier opened this issue Feb 8, 2016 · 4 comments

Comments

@ishahrier
Copy link
Contributor

in the ShopifyProductFilterOptions class

    [JsonProperty("title")]
    public **long**?Title { get; set; } = null;
    [JsonProperty("vendor")]
    public **long**? Vendor { get; set; } = null;
    [JsonProperty("handle")]
    public **long**?Handle { get; set; } = null;
    [JsonProperty("product_type")]
    public **long**? ProductType { get; set; } = null;

these should be string type.
thanks

@mooglegiant
Copy link
Contributor

I already ran into this testing a product search, and already added it to my pull request #27.

@ishahrier
Copy link
Contributor Author

Great!!
I don't know how to commit or give you guys my changes...I have worked on CustomCollection and Smart Collection I just don't know how to put it back into git hub ..I am just not familiar with git hub :S

@mooglegiant
Copy link
Contributor

You would fork your own version from GitHub, Edit in visual studio, Commit it to your fork, then from your fork, you have to create a pull request. Then Nozzle can see it as a pending change and commit it to his main branch. GitHub has a decent walkthough on the step by step process.

@nozzlegear
Copy link
Owner

Thanks for pointing this out! Not sure how I missed this, looks like a copy-paste gone wrong. I've got @mooglegiant's changes merged into the master branch.

nozzlegear pushed a commit that referenced this issue Jan 16, 2020
Merging nozzlegear/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants