Added IServiceFactory<T> + Refactor DI #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created IServiceFactory<T> and updated all Factories to use this new interface. Refactor test cases for dependency injectio to validate all factories using the base generic interface.
nozzlegear
approved these changes
Feb 5, 2024
|
This is awesome @adearriba! Thanks a ton for doing this, it makes maintaining the service factories and DI package a lot simpler. |
|
Happy to help! You are welcome 馃槂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Based on my suggestion I did the changes to the factories: #1003.
I also updated DI to automatically include all factories based on the generic interface and updated the DI test case to test all interfaces are added correctly.
Let me know your thoughts and I hope this helps you in some way. 馃槃 I've use a lot ShopifySharp and I'm glad to be of help.