Create country's (Tax regions) service #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work, thank you for the contribution! I'll merge and publish this soon. |
|
Pull request merged! I'm having some trouble with the unit tests (giving errors about unique country names), so I haven't published this to Nuget yet. I'll fix and publish them tomorrow, and update here as soon as it's available. |
|
Sorry for the wait, the list tests were giving me some weird results and constantly returning empty arrays. I ended up having to skip them. The new service class has been published on nuget with ShopifySharp 5.3.0 -- thank you very much for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a service for managing Shopify Countries. I manged to follow the same coding style used in the other services.
Any feedback you have would be appreciated.