Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to netstandard2.0 #715

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

ChaoticIke
Copy link
Contributor

@ChaoticIke ChaoticIke commented Feb 22, 2022

  • Changed to netstandard2.0 to support more frameworks.
  • Downgraded Microsoft.Extensions.Http to lowest version. Higher frameworks can override this with a newer version.
  • Cross target test project (I added netcoreapp2.1 since we haven't updated yet, but it could be removed)

Note:
dotnet frameworks require System.Net.Http from nuget. The <ItemGroup> conditional and net472 target could be moved to Main csproj instead.

Tests:
image

  • Authorization_Tests: Hardcoded data
  • Collect_Tests: http://placehold.it/250x250 not found
  • Collection_Tests: http://placehold.it/250x250 not found
  • CustomerSavedSearchavedSearch_Tests: The following constructor parameters did not have matching fixture data: CustomerSavedSearchavedSearch_Tests_Fixture fixture. Happened when I ran on master branch as well
  • Fulfillment_Tests: Hardcoded location
  • FulfillmentEvents_Tests: Hardcoded location
  • FulfillmentOrder_Tests: Hardcoded location
  • RetryExecutionPolicies_Tests: Our test store is shopify plus
  • ShopifyException_Tests (Rate exceptions): Our test store is shopify plus

@ChaoticIke
Copy link
Contributor Author

I've created a sample branch for net4.5 using preprocessor directives, if you still wanted to support earlier than 4.7.2.
It just changes the DefaultHttpClientFactory to not use the interface and removes the method to set a global default

https://github.com/ChaoticIke/ShopifySharp/tree/net45

@nozzlegear
Copy link
Owner

Thanks for the pull request! I'm planning on reviewing/testing it this week and hopefully merging it if all goes well.

@nozzlegear nozzlegear merged commit f43a071 into nozzlegear:master Mar 8, 2022
@nozzlegear
Copy link
Owner

Many days later this has been released in 5.16.0 on nuget! Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants