Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sales channel REST API implementation #738

Merged
merged 11 commits into from
Aug 5, 2022

Conversation

cmgt
Copy link
Contributor

@cmgt cmgt commented May 4, 2022

Implementation entities and services for Sales channel REST API https://shopify.dev/api/admin-rest/2021-10/resources/checkout

Include tests for product listing and checkout services

Copy link
Owner

@nozzlegear nozzlegear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! There are quite a few new files/classes in here. I've reviewed all of them and just need some hopefully simple changes before I can merge this in. Let me know if you have any questions!

ShopifySharp/Filters/ProductLististingListFilter.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/ProductListingVariant.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/ProductListingVariant.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/ProductListingVariant.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/ProductListingVariant.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/SalesChannel/CheckoutSalesChannel.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/SalesChannel/CreatePayment.cs Outdated Show resolved Hide resolved
ShopifySharp/Entities/SalesChannel/PaymentSalesChannel.cs Outdated Show resolved Hide resolved
@cmgt
Copy link
Contributor Author

cmgt commented Jun 6, 2022

@nozzlegear Thanks for the review. I have fix all the comments and sent the changes

@cmgt cmgt requested a review from nozzlegear June 6, 2022 15:12
@nozzlegear nozzlegear merged commit 96f469c into nozzlegear:master Aug 5, 2022
@nozzlegear
Copy link
Owner

Published in 5.17.0 on Nuget! Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants