Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when no iscomplete correctly in callback #54

Merged
merged 5 commits into from
Nov 25, 2021

Conversation

hansharhoff
Copy link

When not iscomplete occurs in the callback the current implementation returns None which generates server side error in user console. Instead we can raise PreventUpdate() to suppress this issue.

I also added some instructions to Contributing that would help newcomers get to an installed package quicker.
Added packaging to requirements as this is needed to import dash_uploader.

@fohrloop
Copy link
Owner

Hi! Thanks for the PR! I will look at it during the coming days! :) Does this PreventUpdate exist in all supported dash versions?

Copy link
Owner

@fohrloop fohrloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Did not previously see that packaging is required to import dash_uploader. However, requirements.txt is just meant just for developers. Correct place for requirements that should be installed automatically by pip when installing dash-uploader is the install_requires in the setup.py. Could you change the location of this requirement there?

#setup.py 
    install_requires=[
        "dash>=1.1.0",
    ],

@fohrloop
Copy link
Owner

Hi! Thanks for the PR! I will look at it during the coming days! :) Does this PreventUpdate exist in all supported dash versions?

I checked this and the PreventUpdate exists in dash 1.1.0, at least.

@fohrloop
Copy link
Owner

This would be ready to be merged once the packaging requirements is moved from requirements.txt to setup.py.

@hansharhoff
Copy link
Author

Yes, done

@fohrloop fohrloop merged commit 798a82c into fohrloop:dev Nov 25, 2021
@fohrloop
Copy link
Owner

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants