-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exposure analysis test #316
exposure analysis test #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, few more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it confusing that the new tests dir for exposure analysis is placed within the the dir of other tests
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another question: do we handle containment of labels for representative peers?
for example, a potential connection to ns with label {A: val1} and with conn: all , is including also a potential connection to ns with labels {A: val1, B: val2} , for all contained connections. (which makes such a potential connection redundant).
If not, this can be considered in a separate issue.
it is not handled (added a new task ) |
What do you suggest? the thing is that the |
…ch' into test_exposure_analysis_behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6a702b5
into
new_exposure_analysis_first_branch
issue #236
sub task :