Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Remaining ships color schema in Fullscreen mode #1

Open
np25071984 opened this issue Dec 14, 2023 · 2 comments
Open

Fix Remaining ships color schema in Fullscreen mode #1

np25071984 opened this issue Dec 14, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Community contribution or any kind of help much appreciated

Comments

@np25071984
Copy link
Owner

it is hard to read the "Opponent's remaining ships" section when it is Fullscreen mode. I don't know why the background color becomes black but we have to consider it.

image
@np25071984 np25071984 added help wanted Community contribution or any kind of help much appreciated good first issue Good for newcomers labels Dec 14, 2023
@CzhCN0
Copy link

CzhCN0 commented Dec 15, 2023

@np25071984 Hi mate. The change in background color to black is due to the default styles added by Chrome when handling fullscreen mode. The following CSS takes effect when a non-root element is in fullscreen mode. You only need to add a background color to the "game-boards" element, or alternatively, use a vibrant seascape background.

:not(:root):fullscreen::backdrop {
position: fixed;
inset: 0px;
background: black;
}

@np25071984
Copy link
Owner Author

@CzhCN0 thank you for the response!

the default styles added by Chrome when handling fullscreen mode

I think those default styles make sense so that it is better to update the text color and follow default fullscreen logic

np25071984 pushed a commit that referenced this issue Apr 10, 2024
Fix bug when help button is clicked while another tooltip is on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Community contribution or any kind of help much appreciated
Projects
None yet
Development

No branches or pull requests

2 participants