Multiple updates #46
Closed
Multiple updates #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSDN: GetVersionEx may be altered or unavailable for releases after Windows 8.1. With the release of Windows 8.1, the behavior of the GetVersionEx API has changed in the value it will return for the operating system version. The value returned by the GetVersionEx function now depends on how the application is manifested.
Closed
tim-lebedkov
reviewed
Dec 9, 2019
npackdcl/src/app.cpp
Outdated
| @@ -246,7 +246,7 @@ int App::process() | |||
| build(job); | |||
| } else { | |||
| job->setErrorMessage(QStringLiteral("Wrong command: ") + cmd + | |||
| QStringLiteral(". Try \"ncl help\"")); | |||
| QStringLiteral(". Try \"npackdcl help\"")); | |||
There was a problem hiding this comment.
"ncl" is actually the new name.
There was a problem hiding this comment.
Fixed in 0c3714d
|
I cherry-picked the 2 changes from this pull request: "update german translation" and "Fix compiler warnings". I will close this pull request. Please create a new pull request with CMake changes only where everything builds. |
|
New request #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the german translation file (a95b373).
The MSVC has printed some simple compiler warnings regarding typecasting that are fixed by 464398f.
I've made big changes on the CMake scripts (4aa8b10). Normally under Windows the Qt SDK is not distributed with static libraries, but only with dynamic DLLs. Therefore dynamic linking is now default. However, the NPACKED_FORCE_STATIC_QT switch can be used to force static linking. Instead of completely setting each program individually, all global settings are now set in the CMakeLists.txt in the main directory. There you can also select the projects to be built via switches (NPACKD_BUILD_TESTS, NPACKED_BUILD_CLU, NPACKED_BUILD_NPACKDCL and NPACKED_BUILD_NPACKDG). When installing the dynamically linked projects, the DLLs are no longer copied manually, but by the Qt program windeployqt. The program copies all dependencies and plugins automatically.