add response to successful DeleteGroup context

npauzenga · Jan 16, 2016 · 4620770 · 4620770
1 parent 8dae5ca
commit 4620770
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb
@@ -32,7 +32,9 @@ def update
   def destroy
     result = DeleteGroup.call(id: params[:id])
 
-    unless result.success?
+    if result.success?
+      head :no_content
+    else
       render json: result.errors, status: :internal_server_error
     end
   end

diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb
@@ -197,9 +197,9 @@
     end
 
     context "when DeleteGroup is successful" do
-      it "returns HTTP status 200" do
+      it "returns HTTP status 204" do
         delete :destroy, params
-        expect(response).to have_http_status(200)
+        expect(response).to have_http_status(204)
       end
     end