Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/initial game night model #40

Merged
merged 4 commits into from
Dec 19, 2015

Conversation

npauzenga
Copy link
Owner

Another one for for discussion @enriikke 馃槃

I've got the relationships roughly outlined in issue #29. Perhaps we could talk a little about my associations. This is another has_many :through association for the Users which I think makes the most sense, but I'm still working out how to handle the organizer role. It's just like the group_moderator in that a User creates a GameNight and becomes the organizer.

@@ -0,0 +1,2 @@
class GameNight < ActiveRecord::Base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npauzenga should GameNight belong to a Group?

@enriikke
Copy link
Collaborator

Your testing skills have much improved young padawan. I love how you are structuring them out. Great work on using labels too! I added a comment about GameNights being associated to Groups. I think they should be unless I'm missing something.

:shipit: :yoda: 馃殌

@npauzenga npauzenga merged commit 97c92f8 into staging Dec 19, 2015
@npauzenga npauzenga deleted the features/initial-game-night-model branch December 19, 2015 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants