Features/password-reset-interactors #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npauzenga
changed the title
|
specs are green on both organizers and a couple of the interactors. I'll add specs for the remaining interactors next. CI builds are failing because of a couple tests related the |
|
This looks great @npauzenga!!! 👍 🎅 |
npauzenga
added a commit
that referenced
this pull request
Jan 5, 2016
…tors Features/password-reset-interactors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @enriikke here's the first of two specs for our password_resets_controller interactors. How do you like this structure? I'm a little bit more explicit here in testing the output validation and I think I might go back and do the same for my other interactor tests.