Initial pass at Error classes #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m starting with InvalidParamsError in the UpdateUser interactor. The class will eventually need to be more dynamic but if the pattern works we can implement it everywhere.
|
This is a great start @npauzenga!!! 👍 It's hard for me to say because I'm also in the process of defining this flow myself. The main thing you have to keep in mind is consistency in my opinion. I agree with you that |
|
closed in favor of #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @enriikke!
I'm just getting a basic framework together for
Errorclasses. I don't know exactly what I'd like them to take as arguments.InvalidParamsError.new(params)or similar could be useful for a more detailed description but I'm not sure.The
Error.codeis also currently separate from the HTTP status the controller will return and that's a little confusing. Perhaps I make the code the HTTP status code and do something likestatus: result.errors.first.code... though that's pretty ugly.Thoughts?