Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to take credentials from kubernetes secrets #5

Open
runitmisra opened this issue Sep 25, 2023 · 4 comments
Open

Add option to take credentials from kubernetes secrets #5

runitmisra opened this issue Sep 25, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@runitmisra
Copy link
Contributor

runitmisra commented Sep 25, 2023

Many credentials are being used in the deployments like username and password/identity secrets for peers, orderers, CAs, etc. Along with passing these values as plaintext in helm values file, there should be an option to read these values from kubernetes secrets (like many vendor helm charts offer).

The creation of these secrets is up to the user, weather they create them manually or via some operator like External Secrets Operator.

This will directly help towards the "Manage secrets with secrets management services like Vault, AWS Secrets manager, etc" feature goal.

Example:
The Values file will look something like this:

identity_name: xyz
identity_secret: abc
# Name of the secret resource to take the above two values from. The keys have to be exactly same as above.
identityCredsFromSecret: identity_secret #<--- This is the name of the secret resource where the identity_name and identity_secret is mentioned
@tittuvarghese
Copy link
Member

tittuvarghese commented Sep 25, 2023

@runitmisra Please proceed with the required changes and make a pull request. Also, update the relevant read-me and sample scripts.

May be we should be having a mechanism to setup required secrets in the start of setup. Or possible auto secret generation.

@tittuvarghese tittuvarghese added the enhancement New feature or request label Sep 25, 2023
@jithindevasia
Copy link
Member

@runitmisra Use a single secret for all identity registration under a CA rather than creating individual secrets for every identities. Otherwise we will end-up with 100+ secrets for the TLSCA.

@tittuvarghese
Copy link
Member

@jithindevasia can't we dynamically generate the secrets and it's value. (From a security standpoint let all identities be using a unique secret)

@jithindevasia
Copy link
Member

@jithindevasia can't we dynamically generate the secrets and it's value. (From a security standpoint let all identities be using a unique secret)

Managing/Creating secrets from falcon will lead us to use any cli actions like kubectl or something which will be platform dependent then. I prefer to leave the secret creation/management outside falcon. So people can have their own way to manage secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants