Use rmapshaper and save geojson files #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -492,6 +492,7 @@ for(i in 1:nrow(cents)){ | |||
| cents$ebike_slc[i] <- sum(l$ebike_slc[j]) | |||
| cents$ebike_sic[i] <- sum(l$ebike_sic[j]) | |||
|
|
|||
| if(length(j) == 0) next | |||
There was a problem hiding this comment.
The NANs were causing a problem for the geojson outputing, is it ok to just skip them @Robinlovelace ?
There was a problem hiding this comment.
If this works, go with it. j represents the home location of the centroid in l and if no lines have their origin in cents[i] then yes the loop should skip to the next one. Reasonable fix - will be less relevant when we use more lines. Thanks for asking for feedback, liking the PR workflow.
Robinlovelace
added a commit
that referenced
this pull request
Jan 18, 2016
Use rmapshaper and save geojson files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.