Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make colour ramp have quantile bins #15

Closed
Robinlovelace opened this issue Apr 9, 2015 · 9 comments
Closed

Make colour ramp have quantile bins #15

Robinlovelace opened this issue Apr 9, 2015 · 9 comments

Comments

@Robinlovelace
Copy link
Member

Can we please make the colour bins scale to the quartiles? Currently there are only a couple of zones in the 'greenest' bins in my updated colourscheme: http://geo8.webarch.net/pct-shiny/manchester/ Ideally we need to have quantile bins as explained here: http://www.ncgia.ucsb.edu/cctp/units/unit47/html/comp_class.html

@nikolai-b
Copy link
Contributor

Made some progress on this in dbd2810 , is this what you were after?

@Robinlovelace
Copy link
Member Author

Code looks good but it's not working - think my changes may have broken it. Sorry! Let me know when this up-and-running!

@nikolai-b
Copy link
Contributor

Sure, I think it was when you reverted the colour ramp changes that it re-introduced some old code, easily done. I'm not totally sure I've implemented the quartiles how you wanted but now it works can you have a look and close this if it is?

@Robinlovelace
Copy link
Member Author

Looks good.

@usr110
Copy link
Member

usr110 commented Apr 13, 2015

@nikolai-b
Thanks for the changes in the legend. It looks really nice.
One thing I've noticed, however, that the y-axis doesn't correspond to the underlying values for the selected zone attribute (the range doesn't correspond to the range of the y-axis). Is this something intentionally introduced?

@Robinlovelace
Copy link
Member Author

@usr110 I don't think this is intended. Please try to fix if you can...

Look forward to catching up!

Robin

@usr110
Copy link
Member

usr110 commented Apr 13, 2015

@Robinlovelace I have fixed the errors, I believe - also the dependency with the inputs, for the legend. Could you please update the code on the server? I will then test it out.

@Robinlovelace
Copy link
Member Author

I think it is updated - please test:
http://geo8.webarch.net/pct-shiny/master/
Fantastic work Ali, many thanks.

@nikolai-b
Copy link
Contributor

re #15 (comment), sorry that was my mistake. I didn't realize that using isolate in render plot would mean the value never got updated (maybe because as render plot itself is only called once but it is re-evaluated constantly - the Shiny way). Closing now as this seems done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants