Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to training materials #831

Closed
wants to merge 9 commits into from

Conversation

Robinlovelace
Copy link
Member

No description provided.

@Robinlovelace Robinlovelace mentioned this pull request Mar 31, 2020
This is the standard value and we had https which is invalid
Style tag is not valid in the body tag, also this CSS is not used.
Copy link
Contributor

@nikolai-b nikolai-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine but might want others to check if they are happy with content. 👍

@Robinlovelace
Copy link
Member Author

Also this PR should be to master now.

Copy link
Contributor

@nikolai-b nikolai-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you got a PR to merge into https://github.com/npct/pct-shiny/tree/pct_essentials branch? Maybe I've missed something but this is a bit confusing.

@Robinlovelace Robinlovelace deleted the Robinlovelace-patch-1 branch April 7, 2020 08:10
@Robinlovelace
Copy link
Member Author

Why have you got a PR to merge into https://github.com/npct/pct-shiny/tree/pct_essentials branch?

I don't anymore. I created it before the essentials branch was merged and left it open deliberately to make the useful conversations there more prominent. I should have said 'Replaces #831 ' in the discussion of #835 . Will do the that with this one.

@Robinlovelace Robinlovelace mentioned this pull request May 26, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants