Use SourceLink

[roji]

It's pretty clear that the old-style SymbolSource-based way of doing things doesn't make sense anymore. There seem to be lots of options floating around out there, make sense of it all:

• Embed PDB in the nuget package
• Embed PDB in the assembly (Proposal: Add compiler switch to embed PDB inside the assembly dotnet/roslyn#12390)
• SourceLink (have the PDB point to github), https://github.com/ctaggart/SourceLink.
• Embed sources in the PDB (Add support for embedding C# source in portable pdb dotnet/roslyn#12353). Apparently not yet supported by debugger: https://visualstudio.uservoice.com/forums/121579-visual-studio-ide/suggestions/19107733-debugger-should-support-c-compiler-embed-optio)

Maybe it's possible to use both SourceLink and source embedding

[roji]

Embedded sources will only be supported by VS 2017 15.5 (in preview).

[roji]

Am simply going to do the current recommended best practice (aspnet/Universe#131 (comment)):

• Include the PDB in the main nupkg
• Use SourceLink to link to github

[A13xs]

I think something is wrong in symlink

[roji]

Thanks @A13xs, we should fix that. It's also odd that it says that the build is non-deterministic.

[roji]

On second thought I opened #3063 to track this.