Fix org.freedesktop.DBus.Error.ServiceUnknown errors without polkitd #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception handling for getting the org.freedesktop.PolicyKit1.Authority interface needs to be done in the _interface property method otherwise this could lead into unexpected behaviour where self._interface in _polkit_present is not None if polkit is not present. If polkit is not present self._interface.CheckAuthorization should not be called in IsSystemBusNameAuthorizedAsync. This fixes RHBZ#1393488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception handling for getting the org.freedesktop.PolicyKit1.Authority
interface needs to be done in the _interface property method otherwise this
could lead into unexpected behaviour where self._interface in
_polkit_present is not None if polkit is not present.
If polkit is not present self._interface.CheckAuthorization should not be
called in IsSystemBusNameAuthorizedAsync.
This fixes RHBZ#1393488