Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fixing issues with falsy values in format #49

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Bugfix: Fixing issues with falsy values in format #49

merged 2 commits into from
Oct 18, 2019

Conversation

knicefire
Copy link
Contributor

Fixing issues

  • In case a value is undefined the { symbol is rendered instead of leaving it as is
  • In case a value is falsy (0, '', null, false) the { is rendered instead of the value itself

Testing framework

  • Added mocha testing framework
  • Added tests for formatter

Git hook

  • Enforcing of npm test on pre-push via magic of husky

@AndiDittrich
Copy link
Member

Hi @knicefire

thanks for your contribution.

the changes to the formatter are ok but i didn't confirm with the testcases/libs


therefore please apply the following changes:

  • remove chai and husky
  • move the required test configurations test/_defaults.js into the test file
  • use name.test.js for all testcases
  • use standard assert library

example: https://github.com/AndiDittrich/Node.fs-magic/blob/master/test/mkdirp.test.js

@knicefire
Copy link
Contributor Author

@AndiDittrich
Thanks for the quick reaction and the feedback.

You are right I shouldn't have assumed that adding husky and chai is something the project really needed.

I've done all the required updates listed above.

@AndiDittrich AndiDittrich merged commit 9412750 into npkgz:master Oct 18, 2019
@knicefire knicefire deleted the bugfix/broken-template-for-unkown-values branch October 18, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants