Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use consistent naming in README #50

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

justsml
Copy link
Contributor

@justsml justsml commented Oct 27, 2019

Thanks for the great library! 馃帀

It's faster to implement than other popular libraries on NPM. 馃

My main goal is for cli-progress to appear more modern/familiar by updating the syntax in the README examples.

@AndiDittrich
Copy link
Member

Hi @justsml

it's ok to change this within the readme/docs - but the codebase shouldn't be touched.

especially the undercores are use to indicate global vars within a module (corporate coding styles..)

best regards, Andi

@AndiDittrich AndiDittrich added enhancement validated issue validated by maintainer labels Oct 27, 2019
@AndiDittrich AndiDittrich merged commit f311db1 into npkgz:master Oct 27, 2019
@justsml
Copy link
Contributor Author

justsml commented Oct 28, 2019

Awesome, thanks Andi!!!

@justsml justsml deleted the patch-1 branch October 28, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement validated issue validated by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants